feat(vscode-web): use VS Code code CLI instead of VS Code code-server
#411
Conversation
|
@matifali this would be a good opportunity to use the new individual version tag structure when releasing. |
|
Yes, if this lands, it should go as 2.0.0 for vscode-web. @bcpeinhardt can you take care of this? |
matifali
changed the title
code CLI instead of VS Code code-server
|
Hi @Ricky-Hao, Sorry for not coming to this earlier. We were sorting versions for the modules, and as this module changes stuff significantly while Aldo breaks a few existing =g use cases, We needed that to land this in. Can you update the |
|
I would also like @michaelbrewer to review as he has contributed to this module in past. |
Hi @Ricky-Hao, why can we not support these two features with VS Code's |
Hi @matifali, sorry for the delayed response. |
|
I think the difference here is that |
|
We are moving to https://github.com/coder/regitsry. Please move your PR there. Thanks |
Hi,
The current VSCode Web module directly uses
code-serverto start a VSCode Web instance.However, I noticed that the current VSCode Web only stores user credentials (e.g., GitHub authentication) in in-memory storage.
After investigating the VSCode source code, I discovered that VSCode Web requires a key from the
/mint-keyendpoint.In Coder's
code-server, the/mint-keyendpoint is implemented.However, in the official VSCode version, the
/mint-keyfunctionality is only available in the VSCode CLI (codebinary).To enable credential persistence, we need to use
code serve-webto start a VSCode Web instance instead of the currentcode-server serve-local.In this PR, I updated the process to use
code serve-webto start a VSCode Web instance.Most of the features from the old
code-serverare supported, except for the following two:OFFLINEUSE_CACHEI did not remove these variables from the
.tffiles to maintain compatibility.